Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
🚀 New features to boost your workflow:
|
Owner
|
This is breaking but probably pretty uncommon. A type could implement struct X;
impl std::ops::Deref for X {
type Target = str;
fn deref(&self) -> &Self::Target { "" }
}
fn ok(v: &str) {}
fn breaking<'a>(v: impl Into<std::borrow::Cow<'a, str>>) {}
fn main() {
ok(&X);
breaking(&X);
}If memory serves, we have breaking changes in main already so I'm pulling it in. |
Collaborator
Author
|
Huh, fascinating! I honestly didn't know Deref worked like that! I thought the only type that satisfied a In that case, let's document this as breaking accordingly and make sure to include in the next minor release. Thanks for flagging. |
Collaborator
Author
|
Actually, I think the changelog is fine as is. Since we have harder unreleased breaks, I'll assume you're ok with this and will proceed with merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-breaking change. Accept owned or borrowed strings as input in
Token::from_encoded.