Replace subprocess.call() with check_call() in db.py to prevent silent failures#3580
Conversation
… to prevent silent failures Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
shlokgilda
left a comment
There was a problem hiding this comment.
LGTM. Love the short, targeted PR. Added one suggestion to fix a docstring that was incorrect even before this change.
Signed-off-by: guptapratykshh <pratykshgupta9999@gmail.com>
|
Waiting on Podman end to end test. The fundamental difference here is really the provision of detailed error messages in |
MoralCode
left a comment
There was a problem hiding this comment.
check_call will raise an exception if something fails.
the way we use call here currently (not storing the results in a variable) effectively means we ignore failures
While this may lead to more crashes, they are crashes that would otherwise be maskes, so knowing about them is better
LGTM
Description
I replaced subprocess.call with check_call in the database cli, ensuring that operations stop immediately and report errors if something goes wrong.
This PR fixes #3579
Notes for Reviewers
Signed commits