Draft
Conversation
…rs at once Signed-off-by: David Martin <david@chaoiq.io>
…list of errors in message Signed-off-by: David Martin <david@chaosiq.io>
b056040 to
2cacb7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 86.41% 86.83% +0.42%
==========================================
Files 23 23
Lines 1627 1664 +37
==========================================
+ Hits 1406 1445 +39
+ Misses 221 219 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Lawouach
This is the first version of global validation for the experiment syntax.
This is appending/extending a list of Exception instances along the validation line and reporting all errors at once, at the end of experiment validation (before raising a global exception that is matched & logged by the CLI)
Improvement, in this version, for each error we create an instance of a sub class of ChaosException. We might simplify to only handle a list of errors messages as strings.
To be continued, if we choose this solution, the hypothesis module still need to be updated