Send host header to Decoupled Router.#856
Open
longwave wants to merge 1 commit intochapter-three:mainfrom
Open
Send host header to Decoupled Router.#856longwave wants to merge 1 commit intochapter-three:mainfrom
longwave wants to merge 1 commit intochapter-three:mainfrom
Conversation
|
@longwave is attempting to deploy a commit to the Chapter Three Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Well, except this doesn't really work because it makes all requests dynamic as soon as you look at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is for: (mark with an "x")
examples/*modules/nextpackages/next-drupalstarters/basic-starterstarters/graphql-starterstarters/pages-starterGitHub Issue: #332
Please add a link to the GitHub issue
where this problem is discussed.
Code changes need test coverage. If you don't know
how to make tests, check this box to ask for help.
Describe your changes
This is an alternative to the suggestion in #332, instead of needing different Drupal base URLs we pass on the host header from the original request as a query parameter to Decoupled Router. I also have an extended version of Decoupled Router that interprets that query parameter and passes it to Domain module, allowing decoupled multi-domain setups with a single Drupal backend URL.