Skip to content

fix: handle OS-specific restrictions when moving Output frames #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iusmac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle OS-specific restrictions when moving Output frames #619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion evaluator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,15 @@ func Evaluate(ctx context.Context, tape string, out io.Writer, opts ...Evaluator
defer func() {
if v.Options.Video.Output.Frames != "" {
// Move the frames to the output directory.
_ = os.Rename(v.Options.Video.Input, v.Options.Video.Output.Frames)
err := os.Rename(v.Options.Video.Input, v.Options.Video.Output.Frames)
if err != nil {
// On some systems, Rename may fail with the error message
// "invalid cross-device link" when source and target are on
// different mounts. It may also fail, if the target (output)
// directory already exists, even if it's empty. CopyFS can
// handle the above, while keeping the existing files intact.
_ = os.CopyFS(v.Options.Video.Output.Frames, os.DirFS(v.Options.Video.Input))
}
}

_ = v.Cleanup()
Expand Down