Add doughnutLabel type to AnnotationTypeRegistry#959
Merged
stockiNail merged 1 commit intochartjs:masterfrom Dec 13, 2024
Merged
Add doughnutLabel type to AnnotationTypeRegistry#959stockiNail merged 1 commit intochartjs:masterfrom
stockiNail merged 1 commit intochartjs:masterfrom
Conversation
stockiNail
changed the title
Collaborator
|
@Tmccleerey thank you! |
Collaborator
|
@kurkle @LeeLenaleee there is a code climate issue related "similar" code. In my opinion, it should be ignored but I cannot do it and your support is needed. |
LeeLenaleee
approved these changes
Dec 13, 2024
Collaborator
|
Its an optional step so it is not blocking for this change. I am not sure if it will still show up on following pr's. If so I will try and take a look at it |
Member
|
Looks like I don't have the permission to add ignores there anymore. But as @LeeLenaleee said, codeclimate is informative, not blocking. So you can do the ignoring while pressing merge 😄 |
Collaborator
|
uhm... a bit weird because before @LeeLenaleee approval the merge button was disabled to me. Next time it will happen, I'll check more carefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.