Issue #10969: Fix false positives for pattern variables in RequireThisCheck#18813
Open
Shubhamyadav93 wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #10969: Fix false positives for pattern variables in RequireThisCheck#18813Shubhamyadav93 wants to merge 1 commit intocheckstyle:masterfrom
Shubhamyadav93 wants to merge 1 commit intocheckstyle:masterfrom
Conversation
…RequireThisCheck
Member
|
Please read and watch videos at Starting_Development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
I've updated the RequireThisCheck logic to handle pattern variables correctly. Previously, the check was failing to recognize pattern variables as local declarations, causing false positive violations for the this. qualifier even when a pattern variable was shadowing a field.
I have added PATTERN_VARIABLE_DEF to the identified local variables list. I also added a regression test in RequireThisCheckTest.java to confirm the fix.
Issue: #10969