Add support for Akkoma's move notification#885
Open
Steffo99 wants to merge 6 commits intocheeaun:mainfrom
Open
Add support for Akkoma's move notification#885Steffo99 wants to merge 6 commits intocheeaun:mainfrom
move notification#885Steffo99 wants to merge 6 commits intocheeaun:mainfrom
Conversation
Contributor
Author
|
Seems to be working fine so far!
(Don't mind the green icons, they're still grey here, I've recolored anything related to follows to green in my fork...) |
cheeaun
reviewed
Nov 12, 2024
| {showAcct && ( | ||
| <> | ||
| <br /> | ||
| {' '} |
Owner
There was a problem hiding this comment.
This change seems like could cause some layout issues.
Contributor
Author
There was a problem hiding this comment.
Seems to me that it's necessary to prevent them, actually!
With <br>:
With {' '}:
Owner
There was a problem hiding this comment.
The <br> is used for the large-size post. Maybe need to rename or add another prop to allow both cases.
# Conflicts: # src/components/ICONS.jsx # src/components/notification.jsx # src/locales/en.po
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which currently gets displayed as
[Unknown notification type: move].This had little-to-no testing, it's very rare that people move...
The single notification I had in my history worked exactly as expected, and I plan to keep this on my personal branch to see if it causes any issues for now if you don't plan to merge it yet.