add feature: user should not change the pronunciation of an alphabet#220
Open
harryoooooooooo wants to merge 1 commit intochewing:masterfrom
harryoooooooooo:chewing-editor-issue79
Open
add feature: user should not change the pronunciation of an alphabet#220harryoooooooooo wants to merge 1 commit intochewing:masterfrom harryoooooooooo:chewing-editor-issue79
harryoooooooooo wants to merge 1 commit intochewing:masterfrom
harryoooooooooo:chewing-editor-issue79
Conversation
Member
|
What if I typed "ㄅㄉ" with bopomofo "ㄇ ㄋ"? |
Author
|
I think we should not modify the pronunciation of a single alphabet. |
Member
|
The truth is though we added a phrase with impossible bopomofo, chewing still not provides these phrase according to its built-in bopomofo mapping. So even we added a phrase "ㄅㄉ" with bopomofo "ㄇ ㄋ" in the editor, we still cannot type this phrase by the bopomofo we added. And the editor should avoid to adding all these invaild phrases not just this case. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I add the feature discussing in #79.
Just check if the size of phrase and bopomofo are both 1, and also they are not the same,
then the phrase shouldn't be a bopomofo.