update router to check req.url matched path#160
Open
twhtanghk wants to merge 1 commit intochimurai:masterfrom
Open
update router to check req.url matched path#160twhtanghk wants to merge 1 commit intochimurai:masterfrom
twhtanghk wants to merge 1 commit intochimurai:masterfrom
Conversation
1 similar comment
Owner
|
Hi. Thanks for the PR. Think the fix looks valid. Can you fix the code warnings and provide a test plan? https://github.com/chimurai/http-proxy-middleware/blob/master/test/unit/router.spec.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For special case with req.url 'http://host/user/vm/counter' and
Router would forward the request to 1st matched handler instead of the expected 2nd handler. This pull request is to ensure the matching to the first character of path or hostAndPath. Please review.