Conversation
Owner
|
wow! Thanks for the fix @PythonCow. I'll check it out. |
chinchang
reviewed
Oct 13, 2023
| if (node.range[0]>=loop.start && node.range[0]<=loop.end){ | ||
| patches.push({ | ||
| pos: node.range[1], | ||
| str: '\n%d = Date.now();\n'.replace('%d', loop.varName) |
Owner
There was a problem hiding this comment.
@PythonCow this is basically resetting the loop timer after the alert statement. This means if there is a real infinite loop that has alert statements in it, it would run forever because of this reset. Right?
Owner
There was a problem hiding this comment.
Possible solution:
- Just before alert statement we record time in a variable.
- After alert, we subtract the time taken by alert from the loop timer variable
_wmloopvar.
That way time taken by alert statement won't ever be counted in the loop's timer.
Owner
|
@PythonCow I had the comment written in 2017, but damn this Github UI, they were in "pending" state till today. Sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now loops with popup functions (alert, prompt, confirm) like this:
for (var i = 0; i < 6; i++){alert(i);}Will work.
It also works with loops without curly braces, nested loops, and popups called through the window object (e.g. window.alert()).