Slightly awkward system for controlling playback time#33
Open
wadetb wants to merge 1 commit intochipweinberger:mainfrom
Open
Slightly awkward system for controlling playback time#33wadetb wants to merge 1 commit intochipweinberger:mainfrom
wadetb wants to merge 1 commit intochipweinberger:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, not sure if you have any interest in this feature, but my app invokes playing a MIDI keyboard along with a MIDI track, so I need to control time explicitly, and this PR adds a simple API for that using a "time" property.
The awkward part is deciding when to reset the synth - you obviously want to do it when rewinding, but you may also want to do it when skipping forward, as opposed to just advancing time normally.
Perhaps a "seek" API would be better which implicitly resets the synth, but I also need to be able to advance time manually for my use case without the reset.
Anyway, thanks for making this package, it's been very helpful.