(#281) Prevents Creation Of Unrequired Self-Signed Certificate#283
Merged
ryanrichter94 merged 3 commits intomainfrom Feb 18, 2025
Merged
(#281) Prevents Creation Of Unrequired Self-Signed Certificate#283ryanrichter94 merged 3 commits intomainfrom
ryanrichter94 merged 3 commits intomainfrom
Conversation
JPRuskin
force-pushed
the
serviceCertificateThumbprint
branch
from
9f84d14 to
760802b
Compare
JPRuskin
force-pushed
the
serviceCertificateThumbprint
branch
from
760802b to
6b877bd
Compare
JPRuskin
force-pushed
the
serviceCertificateThumbprint
branch
from
6b877bd to
1cae704
Compare
The Chocolatey-Management-Service package generates a self-signed certificate to use if no thumbprint is specified as a parameter. Regardless of if a certificate was specified, we were installing it without a thumbprint and then setting the certificate later. This resulted in an unused self-signed certificate being generated and stored. This change ensures the package gets the appropriate parameter in order to not generate unneeded certificate(s).
Having CertificateThumbprint and Thumbprint treated differently across the scripts is annoying, and can introduce confusion. This change brings all the scripts into the same $Thumbprint (with an alias for folk who instinctively use CertificateThumbprint), and an argument completer.
steviecoaster
approved these changes
Feb 14, 2025
ryanrichter94
approved these changes
Feb 14, 2025
Member
ryanrichter94
left a comment
ryanrichter94
left a comment
There was a problem hiding this comment.
Tested locally and built fine.
Member
Author
|
I fear I'm going to have to push something just to knock GitHub out of it's "checking" loop. Otherwise, I think this is good to merge. |
JPRuskin
force-pushed
the
serviceCertificateThumbprint
branch
from
b024eed to
3498e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This change ensures the Chocolatey Management Service package gets the appropriate parameter in order to not generate unneeded certificate(s).
Motivation and Context
The Chocolatey-Management-Service package generates a self-signed certificate to use if no thumbprint is specified as a parameter.
Regardless of if a certificate was specified, we were installing it without a thumbprint and then setting the certificate later.
This resulted in an unused self-signed certificate being generated and stored.
Testing
Operating Systems Testing
Change Types Made
[ ] Bug fix (non-breaking change).[ ] Breaking change (fix or feature that could cause existing functionality to change).[ ] Documentation changes.Change Checklist
[ ] Requires a change to the documentation.[ ] Documentation has been updated.[ ] Tests to cover my changes, have been added.[ ] All new and existing tests passed?Related Issue
Fixes #281