convert to a pure ES module and adopt some other es niceities#85
Open
mreinstein wants to merge 2 commits intomasterfrom
Open
convert to a pure ES module and adopt some other es niceities#85mreinstein wants to merge 2 commits intomasterfrom
mreinstein wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't replace all uses of
varwithconst/letin the main module, because I believe there are some places where we're actually depending on var's function scope. That would be a nice future effort.When this lands it'll require another major version bump since dropping commonjs is a breaking change.
I don't know if anyone is still looking at this repo but I'll leave this PR open for a little while in case there are any 👀
Would love feedback.