Updated Plugin, Gradle, Doc & Migrated to null-safety #4
Open
amosogra wants to merge 7 commits intocimplesid:masterfrom
Open
Updated Plugin, Gradle, Doc & Migrated to null-safety #4amosogra wants to merge 7 commits intocimplesid:masterfrom
amosogra wants to merge 7 commits intocimplesid:masterfrom
Conversation
cimplesid
reviewed
Apr 17, 2022
| body: IndexedStack( | ||
| index: index, | ||
| children: [ | ||
| ListView( |
Owner
There was a problem hiding this comment.
will you be able to change this to the builder ? the listview builder
cimplesid
reviewed
Apr 17, 2022
| @override | ||
| void initState() { | ||
| super.initState(); | ||
| keyLogger.logs((log) { |
Owner
There was a problem hiding this comment.
this doesn't seem to match with the updated one
Owner
There was a problem hiding this comment.
basically, the whole code here should be either matching to updated API or no code
cimplesid
reviewed
Apr 17, 2022
| ), | ||
| ], | ||
| ), | ||
| ListView( |
cimplesid
requested changes
Apr 17, 2022
Owner
cimplesid
left a comment
cimplesid
left a comment
There was a problem hiding this comment.
Check some comments.Thanks for great effort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check out this update and let me know if you are satisfied with it. I am open to more changes