Restructure Readme installation section, mention supported Python versions range#25
Open
Spikhalskiy wants to merge 1 commit intocisco:mainfrom
Open
Restructure Readme installation section, mention supported Python versions range#25Spikhalskiy wants to merge 1 commit intocisco:mainfrom
Spikhalskiy wants to merge 1 commit intocisco:mainfrom
Conversation
Spikhalskiy
force-pushed
the
update-deps-readme
branch
2 times, most recently
from
a70260c to
0cde314
Compare
Spikhalskiy
force-pushed
the
update-deps-readme
branch
from
0cde314 to
0778f5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved prerequisites for both installation with pip and installation from sources into a separate section. It makes it more obvious that installed 'libpcap-dev' is a prerequisite.
Explicitly specified the supported range of Python versions: >=3.6,<=3.11
The upper limit comes from the pypcap limitation and can be relaxed after pypcap support for Python 3.12+ is fixed.
Add a note that for an installation from source
/pmercurydir needs to exist and be accessible. // <-- Not a great style btw, maybe worth to change it?