Draft
Conversation
Just a proof of concept.
Owner
|
@Cyrix126 thank you very much for the proof of concept, this should absolutely be doable. I just need to figure out the best way to integrate it. Thanks. |
Hi, |
slundi
reviewed
Apr 7, 2024
slundi
left a comment
slundi
left a comment
There was a problem hiding this comment.
Line 250: use starts_with instead of contains
There is this little discution about it: https://users.rust-lang.org/t/detect-url-or-path/25300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a proof of concept.
At the moment of fetching the url, it checks if it contains "http" in the url. If it doesn't, it tries to load it as a file.
It's very simple but too rudimentary, a lot of things could go wrong (for example if a file name contain the word http), but it works for me with this small change.