Fix name of unittest @classmethod method#243
Open
mdutoo wants to merge 18 commits intockan:masterfrom
Open
Conversation
Minor typo, rephrased HA database setup
Allow to setup logging via environment variables
…nto fix_test_setUpClass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://docs.python.org/3/library/unittest.html#class-and-module-fixtures
else it is never called, and both tests fail using Python 3.5 :
(.venv) $ python -m unittest -v tests/test_mocked.py
test_simple_csv (tests.test_mocked.TestImport) ... /home/mdutoo/dev/ozwillo/workspace/datapusher/tests/test_mocked.py:27: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/mdutoo/dev/ozwillo/workspace/datapusher/tests/static/simple.csv' mode='r' encoding='UTF-8'>
return open(join_static_path(filename)).read()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
ERROR
test_wrong_api_key (tests.test_mocked.TestImport) ... ERROR
======================================================================
ERROR: test_simple_csv (tests.test_mocked.TestImport)
Traceback (most recent call last):
File "/home/mdutoo/dev/ozwillo/workspace/datapusher/.venv/lib/python3.8/site-packages/httpretty/core.py", line 1627, in wrapper
return test(*args, **kw)
File "/home/mdutoo/dev/ozwillo/workspace/datapusher/tests/test_mocked.py", line 81, in test_simple_csv
'api_key': self.api_key,
AttributeError: 'TestImport' object has no attribute 'api_key'
======================================================================
ERROR: test_wrong_api_key (tests.test_mocked.TestImport)
Traceback (most recent call last):
File "/home/mdutoo/dev/ozwillo/workspace/datapusher/.venv/lib/python3.8/site-packages/httpretty/core.py", line 1627, in wrapper
return test(*args, **kw)
File "/home/mdutoo/dev/ozwillo/workspace/datapusher/tests/test_mocked.py", line 106, in test_wrong_api_key
'api_key': self.api_key,
AttributeError: 'TestImport' object has no attribute 'api_key'
Ran 2 tests in 0.002s
FAILED (errors=2)