Open
Conversation
Modified the nested for loops that iterate over the image grid to use numpy vectorization instead, by reshaping the images and titles into 2D arrays, and then iterating over the first dimension of those arrays. This allows for faster iteration and better performance when dealing with large sets of images.
Member
|
@ajinkya-kulkarni Thanks for your awesome contribution! Could you please sign the Contributor License Agreement linked above? Thank you! |
Contributor
|
Hi @ajinkya-kulkarni ! Thank you for the contribution. Could you post some results on performance gains and how the visualizations look like after this change? |
Author
|
I will look into why is it failing. |
Member
|
@ajinkya-kulkarni Any chance you can address the above comments from @sanjanag so we can get this PR in? Thanks! |
Member
|
@ajinkya-kulkarni Any updates on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the nested for loops that iterate over the image grid to use numpy vectorization instead, by reshaping the images and titles into 2D arrays, and then iterating over the first dimension of those arrays. This allows for faster iteration and better performance when dealing with large sets of images.