Adding application/octocat-stream to list of inspectable MIME types#211
Open
shawnHartsell wants to merge 1 commit intocli:trunkfrom
Open
Adding application/octocat-stream to list of inspectable MIME types#211shawnHartsell wants to merge 1 commit intocli:trunkfrom
shawnHartsell wants to merge 1 commit intocli:trunkfrom
Conversation
…or http client logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #210
Relates to: github/rest-api-description#5178
This pull request updates the logic for determining which MIME types are considered "inspectable" and adds comprehensive unit tests to ensure correct behavior. The main change is the inclusion of the
application/octocat-streamMIME type as inspectable.I also manually tested this change by replacing the
cli/go-ghpackage for cli/cli locally and verified that runninggh api --verbose /octocatoutput the ASCII art response.