feat(joint-react): [EXPERIMENTAL] Introduce ControlledPaper with React-DOM rendering#3158
Open
samuelgja wants to merge 5 commits intoclientIO:devfrom
Open
feat(joint-react): [EXPERIMENTAL] Introduce ControlledPaper with React-DOM rendering#3158samuelgja wants to merge 5 commits intoclientIO:devfrom
samuelgja wants to merge 5 commits intoclientIO:devfrom
Conversation
…intJS elements and links - Add BatchCache class for managing batched updates for links, ports, and clear views. - Introduce ClearViewCacheEntry and related functions for managing clear view updates. - Create PortUpdateCacheEntry and functions for merging port updates and groups. - Implement state flushing functions to handle element and link updates in a React-friendly manner. - Develop example story demonstrating cell actions with dynamic node and link management. - Define GraphSchedulerData type for unified scheduling of updates across elements, links, and ports.
…using React-DOM - Add ControlledPaper class to extend dia.Paper, allowing external DOM elements management. - Implement methods for registering and unregistering external elements. - Enhance rendering logic to utilize React-provided SVG structure. - Create ReactPaperLink model with empty markup for React to render link content. - Update ReactPaper to support new ControlledPaper features and improve view management. - Introduce ReactPaperStore to manage ControlledPaper instances within GraphStore. - Extend GraphStore to handle ReactPaper instances and link geometry updates. - Add utility types and interfaces for ControlledPaper options and external elements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces
ControlledPaper- a new experimental approach for React integration that allows React to manage DOM elements directly via React-DOM, instead of JointJS handling the DOM structure and creating of React DOM portals.Key Changes:
dia.Paperthat delegates DOM management to ReactControlledPaperfor true React-DOM renderingControlledPaperinstances withinGraphStoreNew Components:
ReactPaper- Main component for React-DOM based renderingReactPaperElement- Wrapper for element renderingReactPaperLinkComponent- Wrapper for link rendering withuseLinkLayouthookuseReactPaper- Hook to access the underlyingdia.PaperinstanceMotivation and Context
This experimental approach explores benefits over the current SVG-based rendering:
Testing
ReactPaperandControlledPaper