generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 32
feat: WAFR Lens. Adding workflow for XLS file generation and YAML -> JSON converstion on each pull #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
omni1504
wants to merge
85
commits into
cloud-foundations-on-aws:main
Choose a base branch
from
omni1504:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workflow test
Workflow test
Testing workflow
Workflow bugfix
grolston
suggested changes
Jul 30, 2024
Contributor
grolston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for contributing! After review I see that your GitHub Action is trying to push a commit back to the main branch. The main branch is a protected branch that will not allow direct pushes. I am not sure if this GitHub Action will work on this repository.
grolston
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Added generate_xls_from_lens.yaml Github actions file, which:
-- Generates WAFR Lens JSON out of YAML
-- Generates XLS File out of JSON using json-2-xls.py script
Resulting JSON and XLS files are pushed into the same branch (PR target)
Locations:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.