fix kj-test & wd-test test coverage reporting#5881
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
da41935 to
d4b324c
Compare
3597eca to
9c70d73
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5881 +/- ##
===========================================
+ Coverage 68.10% 69.67% +1.56%
===========================================
Files 29 397 +368
Lines 2593 105999 +103406
Branches 15 17965 +17950
===========================================
+ Hits 1766 73853 +72087
- Misses 827 21351 +20524
- Partials 0 10795 +10795 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Rebased and force pushed. |
|
Temporarily removed main branch requirement of coverage CI. |
eeca57f to
ef22439
Compare
43fbbf4 to
fc00be3
Compare
|
Marking it as draft for now. While reverting the wd_test changes the coverage started failing again. Unfortunately, custom rule doesn't play well with coverage and we need sh_test in order to generate coverage reports correctly. I'll try to find a common ground. |
fc00be3 to
3229340
Compare
3229340 to
8d45d41
Compare
1b2f2a6 to
783cab5
Compare
783cab5 to
fa020ed
Compare
|
I've managed to get things going with the latest commit. I think this is ready to get merged. Let's for the CI to generate a coverage report first. |
fhanau
left a comment
There was a problem hiding this comment.
LGTM otherwise, only suggestion is to check if any tests can be re-enabled now that coverage is a bit less slow.
This pull-request ensures that Rust tests, wd_test and kj_test are generating proper test coverage (and with correct line coverages).
Current state of the test coverage on main branch can be accessed from https://app.codecov.io/gh/cloudflare/workerd
Improvements
Tests done to improve the speed of the test coverage runner:
experimental_split_coverage_postprocessingwhich had the highest impact on reducing the coverage duration.Current Issues
Some ongoing issues with test coverage:
experimental_split_coverage_postprocessing. In order to fix Rust test coverage, we need to land fix collect coverage script to work with recent changes bazelbuild/rules_rust#3812, and update our rules_rust.