Skip to content

Conversation

@ketanhwr
Copy link
Member

@ketanhwr ketanhwr commented Feb 3, 2026

@ketanhwr ketanhwr marked this pull request as ready for review February 3, 2026 18:06
@ketanhwr ketanhwr requested review from a team as code owners February 3, 2026 18:06
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 3, 2026

Merging this PR will degrade performance by 40.1%

⚡ 12 improved benchmarks
❌ 5 regressed benchmarks
✅ 53 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
JsString_Utf8Length_Utf16_NonFlat_1024 16.1 µs 10.8 µs +48.36%
Encode_TwoByte_8192[TextEncoder][0/2/8192] 146.1 ms 119.4 ms +22.35%
JsString_Utf8Length_Utf16_NonFlat_8192 73.7 µs 25 µs ×2.9
Encode_TwoByte_256[TextEncoder][0/2/256] 7 ms 6.4 ms +9.94%
Encode_TwoByte_1024[TextEncoder][0/2/1024] 19.5 ms 16.4 ms +19.28%
JsString_Utf8Length_Latin1_Flat_256 1.7 µs 2 µs -13.99%
JsString_Utf8Length_Latin1_Flat_1024 4.6 µs 3.2 µs +43.85%
JsString_Utf8Length_Utf16_Flat_1024 8.6 µs 3.2 µs ×2.7
request[RegExpBenchmark] 7.3 ms 8.2 ms -11.55%
JsString_Utf8Length_Latin1_Flat_8192 31 µs 14.1 µs ×2.2
JsString_Utf8Length_Latin1_Flat_32 891.1 ns 1,487.8 ns -40.1%
EncodeInto_ASCII_8192[TextEncoder][1/0/8192] 3.3 ms 3.7 ms -11.17%
JsString_Utf8Length_Latin1_NonFlat_1024 12.1 µs 10.8 µs +12.16%
JsString_Utf8Length_Utf16_Flat_256 2.7 µs 2 µs +35.15%
JsString_Utf8Length_Utf16_Flat_8192 62.9 µs 14.1 µs ×4.5
JsString_Utf8Length_Latin1_NonFlat_8192 41.9 µs 25 µs +67.73%
JsString_Utf8Length_Utf16_Invalid_Flat_256 2.7 µs 3.2 µs -15.61%

Comparing ketan/v8-14.5 (81cbb68) with main (3262926)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ketanhwr
Copy link
Member Author

ketanhwr commented Feb 4, 2026

Hmm arm build is failing due to a legitimate reason.. checking

external/+http_archive+v8/src/objects/objects-inl.h:1604:27: error: no member named 'IsRequired' in 'v8::internal::WriteBarrier'
 1604 |     DCHECK(!WriteBarrier::IsRequired(*this, value));
      |             ~~~~~~~~~~~~~~^
external/+http_archive+v8/src/base/logging.h:166:43: note: expanded from macro 'DCHECK'
  166 | #define DCHECK(condition) DCHECK_WITH_MSG(condition, #condition)
      |                                           ^~~~~~~~~
external/+http_archive+v8/src/base/logging.h:160:23: note: expanded from macro 'DCHECK_WITH_MSG'
  160 |     if (V8_UNLIKELY(!(condition))) {          \
      |                       ^~~~~~~~~
external/+http_archive+v8/include/v8config.h:665:54: note: expanded from macro 'V8_UNLIKELY'
  665 | # define V8_UNLIKELY(condition) (__builtin_expect(!!(condition), 0))
      |                                                      ^~~~~~~~~
1 error generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants