chore: run type tests only in Python>=3.13#60
Merged
ryanking13 merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
c436cec to
6121c45
Compare
Contributor
|
I think the commit message should say "chore" here since otherwise it will make a release. |
hoodmane
approved these changes
Jan 21, 2026
Contributor
hoodmane
left a comment
There was a problem hiding this comment.
Thanks. As I said, please change commit message to say "chore:" instead of "fix:".
Contributor
Author
|
I think the commit message should say "chore" here since otherwise it will make a release. Oh, I see. Thanks for the heads up. Didn't know we are using commit message-based release. |
6121c45 to
dededb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The typing generated by
ts-to-pythonpackage uses Python>=3.13 syntax (https://peps.python.org/pep-0696/), which is currently making the CI failThe problematic syntax is setting the default value for the generic, which is supported only after Python 3.13.
Maybe we can improve ts-to-python library to handle this case, but to unblock other pull requests, I changed the test to be only run in python 3.13, and included Python 3.13 in CI