skip dns validation for http_proxy#1823
Open
kart2bc wants to merge 2 commits intocloudfoundry:developfrom
Open
skip dns validation for http_proxy#1823kart2bc wants to merge 2 commits intocloudfoundry:developfrom
kart2bc wants to merge 2 commits intocloudfoundry:developfrom
Conversation
jochenehret
requested changes
Feb 5, 2026
Contributor
jochenehret
left a comment
jochenehret
left a comment
There was a problem hiding this comment.
Looks ok, but can you please add a unit test in helpers/config/config_test.go?
Author
thanks for reviewing. I have included the necessary test cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Are you submitting this PR against the develop branch?
The PR is submitted to develop.
All PR's to CATs should be submitted to develop and will be merged to main once they've passed acceptance.
What is this change about?
CF Acceptance Tests (CATS) performs DNS validation during configuration loading that fails when running in environments that require an HTTP proxy for external connectivity. Added a configuration flag to skip DNS validation.
Please provide contextual information.
#1822
What version of cf-deployment have you run this cf-acceptance-test change against?
Please check all that apply for this PR:
Did you update the README as appropriate for this change?
If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?
CATs should validate common operator workflows.
CATs is not a regression test suite.
CATs is run by every component team to validate their releases before promotion.
How many more (or fewer) seconds of runtime will this change introduce to CATs?
What is the level of urgency for publishing this change?
Tag your pair, your PM, and/or team!
It's helpful to tag a few other folks on your team or your team alias in case we need to follow up later.