[v8] Command "unbind-service" can handle multiple bindings #3665
+390
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* see https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0040-service-binding-rotation.md#cf-cli * add parameter "--guid" to delete only a specific binding
15 tasks
anujc25
reviewed
Feb 3, 2026
Contributor
anujc25
left a comment
anujc25
left a comment
There was a problem hiding this comment.
Just one minor comment about updating the integration tests otherwise LGTM.
| case nil: | ||
| case actionerror.ServiceBindingNotFoundError: | ||
| cmd.UI.DisplayText("Binding between {{.ServiceInstanceName}} and {{.AppName}} did not exist", cmd.names()) | ||
| cmd.UI.DisplayText("Binding between {{.ServiceInstanceName}} and {{.AppName}} does not exist", cmd.names()) |
Contributor
There was a problem hiding this comment.
This change requires changes in the integration test as the integration test is failing because of this change.
Test Details:
- Test Name: unbind-service command > when targeting a space > binding does not exist > succeeds saying the binding did not exist
- Test File:
integration/v7/isolated/unbind_service_command_test.go:252
What the CLI actually outputs:
Binding between INT-SI-int-9fdf09b3-2b4e-4824-4bf7-3a91cf9f2a60 and INTEGRATION-APP-int-3ac77377-8c7d-4433-75b6-2c4da19ad19d does not exist
OK
What the test expects to find:
Binding between INT-SI-int-9fdf09b3-2b4e-4824-4bf7-3a91cf9f2a60 and INTEGRATION-APP-int-3ac77377-8c7d-4433-75b6-2c4da19ad19d did not exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
The "unbind-service" command shall be able to handle multiple bindings per (app, service instance). This PR first retrieves the list of all bindings for a given app and a given service instance name. Then it loops over the list and calls
DELETE /v3/service_credential_bindings/:guidfor each item. A new parameter "--guid" allows to delete only a specific bindingWhy Is This PR Valuable?
Allows users to delete multiple service bindings with one CF CLI command.
Applicable Issues
https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0040-service-binding-rotation.md#cf-cli
How Urgent Is The Change?
Not super-urgent.
Other Relevant Parties