Skip to content

Fix an inconsistency introduced in v2.14#579

Merged
kibbles-n-bytes merged 1 commit intocloudfoundry:masterfrom
duglin:issue563
Aug 21, 2018
Merged

Fix an inconsistency introduced in v2.14#579
kibbles-n-bytes merged 1 commit intocloudfoundry:masterfrom
duglin:issue563

Conversation

@duglin
Copy link
Contributor

@duglin duglin commented Aug 14, 2018 •
edited
Loading

Inconsistency introduced by: #541

Fixes #563
Fixes #508

Signed-off-by: Doug Davis dug@us.ibm.com

Fix an inconsistency introduced in v2.14
46604d9 
Inconsistency introduced by: cloudfoundry#541

Fixes cloudfoundry#563

Signed-off-by: Doug Davis <dug@us.ibm.com>
@cfdreddbot
Copy link

cfdreddbot commented Aug 14, 2018

Hey duglin!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@leonwanghui
Copy link
Contributor

leonwanghui commented Aug 15, 2018

Also fixes #508

@duglin
Copy link
Contributor Author

duglin commented Aug 15, 2018

@leonwanghui thanks, I updated the first comment

@duglin
Copy link
Contributor Author

duglin commented Aug 21, 2018

@mattmcneeney @pmorie @n3wscott @zrob review?

mattmcneeney
mattmcneeney approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@mattmcneeney mattmcneeney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @duglin !

@kibbles-n-bytes kibbles-n-bytes merged commit ee52006 into cloudfoundry:master Aug 21, 2018
@gberche-orange
Copy link
Contributor

gberche-orange commented Aug 23, 2018

@duglin I believe the text If the response contains "state": "failed" then the Platform MUST send a deprovision request to the Service Broker to prevent an orphan being created on the Service Broker. However, while the Platform will attempt to send a deprovision request, Service Brokers MAY automatically delete any resources associated with the failed bind request on their own. introduced by #354 into the "Polling Last Operation for Service Instances" section still remains:

https://github.com/openservicebrokerapi/servicebroker/blob/master/spec.md#body-1

I understand this text should be removed as this will negatively impacts service instance update failures as reported by @leonwanghui in #508 when broker last operation for service instance endpoint responds with a 200 status with a failed body. I'd then suggest to reopen #508

@duglin duglin deleted the issue563 branch August 23, 2018 18:14
duglin pushed a commit to duglin/servicebroker that referenced this pull request Aug 23, 2018
Part 2 of PR cloudfoundry#579
1675af2 
I missed this part of the spec that had similar text to what we edited
as part of cloudfoundry#579.

So this is part 2 of that PR.

Signed-off-by: Doug Davis <dug@us.ibm.com>
@duglin duglin mentioned this pull request Aug 23, 2018
Open
@duglin
Copy link
Contributor Author

duglin commented Aug 23, 2018

@gberche-orange nice catch!! I opened #591 to try to address it

@mattmcneeney mattmcneeney modified the milestone: 2.15 Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@fmui fmui fmui approved these changes

@kibbles-n-bytes kibbles-n-bytes kibbles-n-bytes approved these changes

@mattmcneeney mattmcneeney mattmcneeney approved these changes

@n3wscott n3wscott n3wscott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15

Development

Successfully merging this pull request may close these issues.

Is the 2.14 spec contradictory around orphan mitigation? Should platforms always send deprovision request when failed to update the service instance?

8 participants

@duglin @cfdreddbot @leonwanghui @gberche-orange @fmui @kibbles-n-bytes @mattmcneeney @n3wscott