Barman Plugin: Conditionally create self-signed Issuer based on certificate settings#749
Open
rezaxd wants to merge 2 commits intocloudnative-pg:mainfrom
Open
Barman Plugin: Conditionally create self-signed Issuer based on certificate settings#749rezaxd wants to merge 2 commits intocloudnative-pg:mainfrom
rezaxd wants to merge 2 commits intocloudnative-pg:mainfrom
Conversation
…r|Client]Certificate is true Signed-off-by: rezaxd <r324r11@gmail.com>
rezaxd
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
the
size:XS
Signed-off-by: rezaxd <r324r11@gmail.com>
dosubot
bot
added
size:S
ianroberts
reviewed
Dec 21, 2025
Comment on lines
+82
to
+92
| {{- if or .Values.certificate.createClientCertificate .Values.certificate.createServerCertificate }} | ||
| volumeMounts: | ||
| {{- if .Values.certificate.createServerCertificate }} | ||
| - mountPath: /server | ||
| name: server | ||
| {{- end }} | ||
| {{- if .Values.certificate.createClientCertificate }} | ||
| - mountPath: /client | ||
| name: client | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
The plugin still requires certificates for mTLS even if you disable the cert-manager generation in the chart. The way things are set up now in the chart, if you don't want to use cert-manager you would have to manually provision the secrets barman-cloud-client-tls and barman-cloud-server-tls with the correct certificates through some other mechanism, I guess it might make sense to allow these secret names to be overridden via chart values rather than requiring these hard-coded names.
gbartolini
added
the
chart( plugin-barman-cloud )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update on Helm template for the Issuer resource so it is created only when certificate generation is explicitly enabled. This caused unnecessary issuer creation even when no client or server certificates were required.