feat: allow specification of revisionHistoryLimit on certificates#763
Open
ianroberts wants to merge 1 commit intocloudnative-pg:mainfrom
Open
feat: allow specification of revisionHistoryLimit on certificates#763ianroberts wants to merge 1 commit intocloudnative-pg:mainfrom
ianroberts wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
Every time cert-manager renews a certificate it creates a new `CertificateRequest` resource for that renewal and, in cert-manager versions older than 1.18.0, old `CertificateRequest` resources are never cleaned up. Version 1.18.0 and later keeps only the latest request by default, but in order to make older cert-manager delete old requests after a renewal it is necessary to specify an explicit `revisionHistoryLimit` on the `Certificate` resource. This change sets a default history limit of 1, matching the default in cert-manager >=1.18.0, but allows this to be overridden via chart values. Fixes cloudnative-pg#762 Signed-off-by: Ian Roberts <i.roberts@sheffield.ac.uk>
ianroberts
requested review from
fcanovai,
gbartolini,
itay-grudev,
leonardoce,
mnencia,
phisco and
sxd
as code owners
dosubot
bot
added
the
size:S
gbartolini
added
the
chart( plugin-barman-cloud )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time cert-manager renews a certificate it creates a new
CertificateRequestresource for that renewal and, in cert-manager versions older than 1.18.0, oldCertificateRequestresources are never cleaned up. Version 1.18.0 and later keeps only the latest request by default, but in order to make older cert-manager delete old requests after a renewal it is necessary to specify an explicitrevisionHistoryLimiton theCertificateresource.This change sets a default history limit of 1, matching the default in cert-manager >=1.18.0, but allows this to be overridden via chart values.
Fixes #762