feat: Make CREATE EXTENSION tests optional#92
Open
mbiagetti wants to merge 1 commit intocloudnative-pg:mainfrom
Open
feat: Make CREATE EXTENSION tests optional#92mbiagetti wants to merge 1 commit intocloudnative-pg:mainfrom
mbiagetti wants to merge 1 commit intocloudnative-pg:mainfrom
Conversation
8eef786 to
0c185f5
Compare
mbiagetti
commented
Jan 29, 2026
Comment on lines
-7
to
-10
| extensions: | ||
| - applied: true | ||
| name: ($values.sql_name) | ||
| observedGeneration: 1 |
Contributor
Author
There was a problem hiding this comment.
I've removed it because when create_extension = false, the Database CR status doesn't have an extensions field at all - it's completely omitted by Kubernetes, not returned as an empty array. So asserting extensions: [] would fail. Let me know if I should dig in the testing framework to improve this part.
0c185f5 to
eb02ddd
Compare
Signed-off-by: Matteo <matteo.biagetti@enterprisedb.com>
eb02ddd to
cf759a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testing framework does not support conditional templating or conditional test execution, so the assertion part is generated but the
generate-testing-valuesDagger command.Result of the generate command for
fixes #85