Skip to content

fix(service-proxy): rm buffer size as hardcoded annotation#1245

Merged
kengou merged 2 commits intomainfrom
fix(service-proxy)-rm-double-annotation
Nov 5, 2025
Merged

fix(service-proxy): rm buffer size as hardcoded annotation#1245
kengou merged 2 commits intomainfrom
fix(service-proxy)-rm-double-annotation

Conversation

@kengou
Copy link
Collaborator

@kengou kengou commented Nov 5, 2025

Removed nginx.ingress.kubernetes.io/proxy-buffer-size: 32k from

annotations:
{{- toYaml . | nindent 4 }}
nginx.ingress.kubernetes.io/proxy-buffer-size: 32k
nginx.ingress.kubernetes.io/ssl-redirect: "true"
{{- end }}
as an annotation from ingress-template.
The same annotation already coming from values.yaml and flux is failing with the deployment.
ingress:
className: ""
annotations:
nginx.ingress.kubernetes.io/proxy-buffer-size: 32k
kubernetes.io/tls-acme: "true"


Replace any ":question:" below with information about your pull request.

Pull Request Details

Provide details about your pull request and what it adds, fixes, or changes.

Breaking Changes

Describe what features are broken by this pull request and why, if any.

Issues Fixed

Enter the issue numbers resolved by this pull request below, if any.

Other Relevant Information

Provide any other important details below.

@kengou kengou requested a review from a team as a code owner November 5, 2025 11:19
@kengou kengou added pr-build-chart Trigger a temporary chart build with the PR number cleanup-pr-chart Cleaning up temporarily built chart in the PR and removed pr-build-chart Trigger a temporary chart build with the PR number labels Nov 5, 2025
@kengou kengou changed the title rm buffer size as hardcoded annotation fix(service-proxy): rm buffer size as hardcoded annotation Nov 5, 2025
@kengou kengou merged commit aa99447 into main Nov 5, 2025
29 checks passed
@kengou kengou deleted the fix(service-proxy)-rm-double-annotation branch November 5, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup-pr-chart Cleaning up temporarily built chart in the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants