Merged
Conversation
trouaux
force-pushed
the
thanos-ruler-component
branch
2 times, most recently
from
709212f to
5531122
Compare
viennaa
requested changes
Nov 27, 2024
trouaux
force-pushed
the
thanos-ruler-component
branch
from
5531122 to
6d0aa6f
Compare
trouaux
force-pushed
the
thanos-ruler-component
branch
from
72b3af0 to
46903d6
Compare
trouaux
changed the title
trouaux
changed the title
ibakshay
reviewed
Jan 21, 2025
ibakshay
reviewed
Jan 21, 2025
Contributor
ibakshay
left a comment
ibakshay
left a comment
There was a problem hiding this comment.
LGTM! left a minor comment :)
viennaa
previously requested changes
Jan 24, 2025
Contributor
viennaa
left a comment
viennaa
left a comment
There was a problem hiding this comment.
Thanks for pursuing the ruler component config 👍.
I think the cert handling is missing here, so we need to ensure to have config in place, to talk to an alertmanager.
Please also add thanosruler.spec.routePrefix to have it available at the ruler subpath after the query url.
viennaa
reviewed
Jan 24, 2025
olandr
pushed a commit
that referenced
this pull request
Feb 28, 2025
* add ruler + ruler-svc templates * remove label helm.sh * lint clean up * ruler bats testing + extra labels * re-org values + clean-up ruler template * values naming fix * update container args + volume mounts * clean up * remove comment conflict * thanos ruler with k8s operator * CI test with prometheus operator * lint fix + chart lock * template objectstore volume for store and compactor * relocate CI folder * lint * values indent * split ci test ressources * clean up * fix bats test + new specs to ruler * test clean up * ruler enabled conditions * test typo * update thanos ruler tests * CI bug * common matching labels for CI * yaml typo * clean up ci yaml values * fix suggestions * alertmanager ressources for ruler config * feat alertmanager config templates * fix configmap name * rework ruler labels * feat: routePrefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #351