Conversation
trouaux
changed the title
richardtief
reviewed
Apr 23, 2025
Member
richardtief
left a comment
richardtief
left a comment
There was a problem hiding this comment.
Thanks. Two thoughts on this below.
richardtief
reviewed
Apr 25, 2025
Member
richardtief
left a comment
richardtief
left a comment
There was a problem hiding this comment.
Thanks for the breakdown. The only task left is to follow the pattern.
viennaa
requested changes
Apr 29, 2025
Contributor
viennaa
left a comment
viennaa
left a comment
There was a problem hiding this comment.
Thanks for bringing them in. I'd like to have couple of changes in regards to severity. Default should be info for most, we can go with a couple warnings, where it makes sense and only very few critical pagers.
I am even not sure, if we should page for thanos at all. Maybe we start with warnings only and increase, where needed.
Contributor
Author
|
updated severities, no critical alerts currently readme update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/monitoring-mixins/website/blob/master/assets/thanos/alerts.yaml
closing #763