Skip to content

feat(dockerfiles) docker images versionning#829

Closed
trouaux wants to merge 1 commit intomainfrom
dockerfile-versioning
Closed

feat(dockerfiles) docker images versionning#829
trouaux wants to merge 1 commit intomainfrom
dockerfile-versioning

Conversation

@trouaux
Copy link
Contributor

@trouaux trouaux commented Apr 29, 2025

  1. extracting version from LABEL of Dockerfile
  2. check if version is already present in image repository
  3. stop workflow if bump is required

@trouaux trouaux requested review from a team as code owners April 29, 2025 07:21
Copy link
Collaborator

@kengou kengou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning is done via tagging, if you push a tag a new image will be created via that tag.
I don't see the benefit of manually maintaining it inside the docker image

push:
branches:
- main
paths:
- Dockerfile.*
tags:
- v*.*.*

@trouaux
Copy link
Contributor Author

trouaux commented Apr 29, 2025

Versioning is done via tagging, if you push a tag a new image will be created via that tag. I don't see the benefit of manually maintaining it inside the docker image

push:
branches:
- main
paths:
- Dockerfile.*
tags:
- v*.*.*

got it thanks for the review, we will start using tags

@trouaux trouaux closed this Apr 29, 2025
@kengou kengou deleted the dockerfile-versioning branch April 29, 2025 07:32
@trouaux trouaux restored the dockerfile-versioning branch April 29, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants