Open
Conversation
Closes cmu-db#285 Closes cmu-db#286 Closes cmu-db#287 Closes cmu-db#288 Closes cmu-db#289
Member
|
@anasY2 What is the meaning for "arcion"? |
apavlo
requested changes
Oct 19, 2023
Member
apavlo
left a comment
apavlo
left a comment
There was a problem hiding this comment.
Thanks for sending this. Can you address the comments? It's not clear why you are bringing in dependencies for Snowflake/MongoDB?
Comment on lines
+52
to
+125
| <profile> | ||
| <id>arcion</id> | ||
| <repositories> | ||
| <repository> | ||
| <id>jumpmind</id> | ||
| <name>jumpmind</name> | ||
| <url>https://maven.jumpmind.com/repo</url> | ||
| </repository> | ||
| </repositories> | ||
| <properties> | ||
| <classifier>arcion</classifier> | ||
| </properties> | ||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.xerial</groupId> | ||
| <artifactId>sqlite-jdbc</artifactId> | ||
| <version>3.36.0.3</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.ibm.db2</groupId> | ||
| <artifactId>jcc</artifactId> | ||
| <version>11.5.8.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.postgresql</groupId> | ||
| <artifactId>postgresql</artifactId> | ||
| <version>42.4.0</version> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/net.snowflake/snowflake-jdbc --> | ||
| <dependency> | ||
| <groupId>net.snowflake</groupId> | ||
| <artifactId>snowflake-jdbc</artifactId> | ||
| <version>3.13.30</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>mysql</groupId> | ||
| <artifactId>mysql-connector-java</artifactId> | ||
| <version>8.0.29</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.mariadb.jdbc</groupId> | ||
| <artifactId>mariadb-java-client</artifactId> | ||
| <version>2.7.8</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.oracle.database.jdbc</groupId> | ||
| <artifactId>ojdbc8</artifactId> | ||
| <version>21.1.0.0</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.microsoft.sqlserver</groupId> | ||
| <artifactId>mssql-jdbc</artifactId> | ||
| <version>11.2.3.jre17</version> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/com.ibm.informix/jdbc --> | ||
| <dependency> | ||
| <groupId>com.ibm.informix</groupId> | ||
| <artifactId>jdbc</artifactId> | ||
| <version>4.50.3</version> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/org.mongodb/bson --> | ||
| <dependency> | ||
| <groupId>org.mongodb</groupId> | ||
| <artifactId>bson</artifactId> | ||
| <version>3.8.0</version> | ||
| </dependency> | ||
| <!-- https://mvnrepository.com/artifact/jdbc.sybase/jconn4 --> | ||
| <dependency> | ||
| <groupId>jdbc.sybase</groupId> | ||
| <artifactId>jconn4</artifactId> | ||
| <version>16.0</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </profile> |
Member
There was a problem hiding this comment.
Why do we need to bring in Snowflake / MongoDB / etc drivers? What is the point of this addition?
Comment on lines
+180
to
+193
| <profile> | ||
| <id>snowflake</id> | ||
| <properties> | ||
| <classifier>snowflake</classifier> | ||
| </properties> | ||
| <dependencies> | ||
| <!-- https://mvnrepository.com/artifact/net.snowflake/snowflake-jdbc --> | ||
| <dependency> | ||
| <groupId>net.snowflake</groupId> | ||
| <artifactId>snowflake-jdbc</artifactId> | ||
| <version>3.13.30</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </profile> |
Member
There was a problem hiding this comment.
Are you adding support for Snowflake? If yes, can you submit that as a separate PR?
Comment on lines
+298
to
+302
| <dependency> | ||
| <groupId>org.mongodb</groupId> | ||
| <artifactId>bson</artifactId> | ||
| <version>3.8.0</version> | ||
| </dependency> |
Member
There was a problem hiding this comment.
Are you adding support for MongoDB now too?
Comment on lines
+260
to
+264
| } catch (java.lang.InstantiationException ex) { | ||
| throw new RuntimeException("Failed to initialize JDBC driver '" + this.driverClass + "'", ex); | ||
| } catch (java.lang.IllegalAccessException ex) { | ||
| throw new RuntimeException("Failed to initialize JDBC driver '" + this.driverClass + "'", ex); | ||
| } |
Member
There was a problem hiding this comment.
Rewrite into a single block:
} catch (java.lang.InstantiationException | java.lang.IllegalAccessException ex) {
Author
Its a profile name. Instead of downloading drivers separately, it will do it all at once so you do not need to build everytime you wanted to run workload for a separate database. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tpcc and ycsb support for sybase ASE and Informix.
pom.xmlhas a new profile namedarcionwhich will deploy a jar file that contains all the database drivers.