Conversation
Signed-off-by: Orlix <orlin@orlix.org>
✅ Deploy Preview for tag-security ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
JustinCappos
left a comment
JustinCappos
left a comment
There was a problem hiding this comment.
I have a few minor requests. It looks good overall. Can you fix these and we'll merge?
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Update K3s self-assessment based on initial TAG review
|
Hi @JustinCappos all comments are addressed and provided update by @brandond. |
JustinCappos
left a comment
JustinCappos
left a comment
There was a problem hiding this comment.
One more minor fix ("fully certified" is ???) and I think it's ready to merge.
|
@JustinCappos it looks like you resolved that discussion so I had to go hunting for it - but see #1500 (comment) |
I think this may just be my lack of understanding in the kubernetes landscape. Seems like this should be fine to merge then. |
JustinCappos
left a comment
JustinCappos
left a comment
There was a problem hiding this comment.
Good to merge. Would require a bit of work for a joint assessment, but is in a decent shape.
|
FYI: the linter and spell checking are failing. Can you fix those please? |
|
It looks like we'll need to add some words to the word list; is that acceptable? |
Yes, go ahead! |
@jkjell @evankanderson @mnm678 notifying you in case there is an objection... |
Signed-off-by: Orlix <orlin@orlix.org>
Signed-off-by: Orlix <orlin@orlix.org>
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
Still approving, but rewriting the entire extra words dictionary to case insensitive was a little hard to review.
| ], | ||
| "words": [ | ||
| "ABAC", | ||
| "addfetnetgrent", |
There was a problem hiding this comment.
Where is this "word" used (out of curiosity)?
There was a problem hiding this comment.
@evankanderson it's in the original file as well - "addfetnetgrent",
There was a problem hiding this comment.
search didn't show it anywhere though, happy to remove it :)
There was a problem hiding this comment.
@evankanderson do you want me to clean this up or we keep it as it was before ?
There was a problem hiding this comment.
Hey @OrlinVasilev, you might want to just bypass this repo and its checks, and put the document directly into it's long-term home instead: https://github.com/cncf/toc/tree/main/projects/k3s
ref: https://github.com/cncf/tag-security/blob/main/.github/pull_request_template.md
|
Now we just need to satisfy the markdown style linter... |
5 participants
K3s project is getting itself prepared for the Incubation phase. We are completing our first self-assessment.