Fix for broken romtool --kickety_split
#235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix kickety split ROM rebuilding
Fixes #234
Summary
This PR fixes a bug in
romtoolthat caused kickety split ROM rebuilding to fail. The rebuilt ROMs had corrupted fill bytes at the 256 KiB boundary, resulting in invalid ROM headers.Changes
RomEntryRomHdr.get_data()- changedb"\x0ff"tob"\xff"Testing
Tests passing with full ROM suite (81 passed, 63 skipped):
Verified with 512 KiB Kickstart ROMs: