Open
Conversation
Member
|
Change your commit message to follow commit guidelines. Also never open a PR from your master branch. |
Author
done, changed the message . for the branch part..i will keep this in mind in future . |
utkarsh2102
reviewed
May 10, 2021
Member
utkarsh2102
left a comment
There was a problem hiding this comment.
Hey,
If you're still interested, just some trivial things:
-> add the issue being fixed in the commit messages.
-> rebase this PR, please.
-> [optional] in case you're interested, you can create a different branch and then change the base easily. You don't need a separate PR for sure!
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue #341