API limit exceed: Show modal by 123vivekr · Pull Request #184 · coala/gh-board

123vivekr · 2019-01-17T05:08:42Z

Shows the error in a user friendly way.

Closes #127

wisn · 2019-01-17T13:38:54Z

@jayvdb @blazeu which JavaScript style guide we use for this repository? Is it Airbnb? I would like to review this pull request.

li-boxuan · 2019-01-17T17:48:47Z

We didn't specify or regulate a javascript style, but airbnb style seems to be the thing we were actually practicing.

wisn

The diff looks weird. Anyway, please follow Airbnb JavaScript style guide. We use two whitespaces as the indentation. Don't change it into four whitespaces.

Also, when you are at it is, edit all const {something} into const { something } would be great. I would do extensive review after this.

123vivekr · 2019-01-18T03:13:26Z

@wisn Thank you for reviewing my Pull Request. I will change my code to follow the airbnb style guide.

This is the modal.

I'm having problem with the state to toggle the visibility of the modal. I am not able to update state within static defaultProps object. Please guide me on what changes I have to make here.
Consequently, the Ok button does not do anything.

PS: Please ignore the dark theme

123vivekr · 2019-01-23T16:45:49Z

I've made the requested changes - changed space indentation to 2 spaces and changed
const {identifier} to const { identifier }

123vivekr · 2019-01-30T16:23:40Z

@wisn Please review my PR

wisn · 2019-01-31T03:35:15Z

@123vivekr Does the modal works now? I don't know why the deploy preview always failed

123vivekr · 2019-02-02T10:56:05Z

@wisn I changed the props to functions and gave a show variable in the state. But the onResolve and onError functions are called (which in turn calls setState) multiple times and causes an infinite loop.

123vivekr · 2019-02-02T10:59:05Z

@wisn Please help figure out the cause of multiple calls to onError and onResolve.

jayvdb · 2019-02-03T08:34:20Z

@gitmate-bot rebase

gitmate-bot · 2019-02-03T08:34:22Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2019-02-03T08:36:40Z

Automated rebase with GitMate.io was successful! 🎉

TravisBuddy · 2019-02-03T08:41:26Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7c20ed10-278f-11e9-81eb-21ccd9c7497f

src/components/loadable.jsx

src/components/board.jsx

TravisBuddy · 2019-02-03T16:36:14Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d0613370-27d1-11e9-81eb-21ccd9c7497f

TravisBuddy · 2019-02-09T04:47:52Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d6fdf350-2c25-11e9-b3d3-256864349aa7

TravisBuddy · 2019-02-09T04:48:57Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fc846d20-2c25-11e9-b3d3-256864349aa7

123vivekr · 2019-02-10T15:50:21Z

This is the final modal.

TravisBuddy · 2019-02-10T15:53:28Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fb35e080-2d4b-11e9-bee6-ebd77371f46a

KVGarg · 2019-02-10T16:12:46Z

@123vivekr I have no knowledge regarding react language, but regarding coding standards I have one question. Since, the code is getting repeated at 1 and 2. So, can we create a single function for it that contains the repeated code and it accepts the args/kwargs for the content which is getting changed i.e. of paragraph, header etc.
If that is possible it will be much good.

123vivekr · 2019-02-10T16:37:58Z

@KVGarg Requested changes have been made. :)
Thank you for the suggestion

KVGarg · 2019-02-10T16:40:26Z

Also, haven't notices the number of commits before, sorry.
Last change, Please squash your commits.
After that 💯

TravisBuddy · 2019-02-10T16:40:59Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a2b85b70-2d52-11e9-bee6-ebd77371f46a

123vivekr · 2019-02-10T16:44:52Z

@KVGarg The commits are for different changes in different files. I don't think they need to be squashed.
Thank you for reviewing.

src/components/loadable.jsx

TravisBuddy · 2019-02-12T01:59:56Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e2ea4b00-2e69-11e9-93d2-519d0ef52680

TravisBuddy · 2019-02-12T02:23:53Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3bba9f70-2e6d-11e9-93d2-519d0ef52680

This shows a modal with error message on exceeding API limit. Closes coala#127

Closes coala#127

TravisBuddy · 2019-02-12T02:30:10Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 183d46a0-2e6e-11e9-93d2-519d0ef52680

TravisBuddy · 2019-02-12T02:32:22Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6a3eeda0-2e6e-11e9-93d2-519d0ef52680

TravisBuddy · 2019-02-12T02:34:27Z

Travis tests have failed

Hey @123vivekr,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b5167960-2e6e-11e9-93d2-519d0ef52680

KVGarg

Dialog box not appearing when API limit got exceeded. Can you take a look why is this happening?
Browsed page url

gitmate-bot added process/pending review size/M enhancement labels Jan 17, 2019

gitmate-bot assigned 123vivekr Jan 17, 2019

wisn suggested changes Jan 17, 2019

View reviewed changes

gitmate-bot added size/S and removed size/M labels Jan 23, 2019

gitmate-bot force-pushed the api-limit-exceed branch from 813ccae to 774b1f0 Compare February 3, 2019 08:35

jayvdb requested changes Feb 3, 2019

View reviewed changes

src/components/loadable.jsx Outdated Show resolved Hide resolved

src/components/board.jsx Outdated Show resolved Hide resolved

jayvdb added process/wip and removed process/pending review labels Feb 3, 2019

123vivekr force-pushed the api-limit-exceed branch from 774b1f0 to c7aca55 Compare February 3, 2019 16:30

gitmate-bot added process/pending review and removed process/wip labels Feb 3, 2019

123vivekr force-pushed the api-limit-exceed branch from c7aca55 to 74cd30f Compare February 3, 2019 17:09

gitmate-bot added size/M and removed size/S labels Feb 3, 2019

123vivekr force-pushed the api-limit-exceed branch from 18faa87 to 20e9211 Compare February 10, 2019 15:48

123vivekr force-pushed the api-limit-exceed branch from 20e9211 to bb7ca78 Compare February 10, 2019 16:35

jayvdb requested changes Feb 11, 2019

View reviewed changes

src/components/loadable.jsx Outdated Show resolved Hide resolved

jayvdb added process/wip and removed process/pending review labels Feb 11, 2019

123vivekr force-pushed the api-limit-exceed branch from bb7ca78 to 16e8dd6 Compare February 12, 2019 01:54

gitmate-bot added process/pending review and removed process/wip labels Feb 12, 2019

123vivekr force-pushed the api-limit-exceed branch from 16e8dd6 to fe6c57b Compare February 12, 2019 02:18

123vivekr force-pushed the api-limit-exceed branch 2 times, most recently from aa72355 to 8627c41 Compare February 12, 2019 02:27

123vivekr added 2 commits February 12, 2019 07:58

loadable.jsx: Show modal on API limit exceed

dd2b661

This shows a modal with error message on exceeding API limit. Closes coala#127

board.jsx: Make error message user friendly

183b7f4

Closes coala#127

123vivekr force-pushed the api-limit-exceed branch from 8627c41 to 183b7f4 Compare February 12, 2019 02:28

KVGarg suggested changes Mar 18, 2019

View reviewed changes

RJ722 mentioned this pull request Sep 8, 2019

router.jsx: Remove unused state & replace parameter #187

Open

Conversation

123vivekr commented Jan 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wisn commented Jan 17, 2019

Uh oh!

li-boxuan commented Jan 17, 2019

Uh oh!

wisn left a comment

Choose a reason for hiding this comment

Uh oh!

123vivekr commented Jan 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

123vivekr commented Jan 23, 2019

Uh oh!

123vivekr commented Jan 30, 2019

Uh oh!

wisn commented Jan 31, 2019

Uh oh!

123vivekr commented Feb 2, 2019

Uh oh!

123vivekr commented Feb 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayvdb commented Feb 3, 2019

Uh oh!

gitmate-bot commented Feb 3, 2019

Uh oh!

gitmate-bot commented Feb 3, 2019

Uh oh!

TravisBuddy commented Feb 3, 2019

Travis tests have failed

TravisBuddy Request Identifier: 7c20ed10-278f-11e9-81eb-21ccd9c7497f

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Feb 3, 2019

Travis tests have failed

TravisBuddy Request Identifier: d0613370-27d1-11e9-81eb-21ccd9c7497f

Uh oh!

TravisBuddy commented Feb 9, 2019

Travis tests have failed

TravisBuddy Request Identifier: d6fdf350-2c25-11e9-b3d3-256864349aa7

Uh oh!

TravisBuddy commented Feb 9, 2019

Travis tests have failed

TravisBuddy Request Identifier: fc846d20-2c25-11e9-b3d3-256864349aa7

Uh oh!

123vivekr commented Feb 10, 2019

Uh oh!

TravisBuddy commented Feb 10, 2019

Travis tests have failed

TravisBuddy Request Identifier: fb35e080-2d4b-11e9-bee6-ebd77371f46a

Uh oh!

KVGarg commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

123vivekr commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KVGarg commented Feb 10, 2019

Uh oh!

TravisBuddy commented Feb 10, 2019

Travis tests have failed

TravisBuddy Request Identifier: a2b85b70-2d52-11e9-bee6-ebd77371f46a

Uh oh!

123vivekr commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TravisBuddy commented Feb 12, 2019

Travis tests have failed

TravisBuddy Request Identifier: e2ea4b00-2e69-11e9-93d2-519d0ef52680

Uh oh!

TravisBuddy commented Feb 12, 2019

Travis tests have failed

TravisBuddy Request Identifier: 3bba9f70-2e6d-11e9-93d2-519d0ef52680

Uh oh!

TravisBuddy commented Feb 12, 2019

123vivekr commented Jan 17, 2019 •

edited

Loading

123vivekr commented Jan 18, 2019 •

edited

Loading

123vivekr commented Feb 2, 2019 •

edited

Loading

KVGarg commented Feb 10, 2019 •

edited

Loading

123vivekr commented Feb 10, 2019 •

edited

Loading

123vivekr commented Feb 10, 2019 •

edited

Loading