DOC-15338: Remove metrics from Essential Metrics Advanced page#20972
DOC-15338: Remove metrics from Essential Metrics Advanced page#20972florence-crl merged 11 commits intomainfrom
Conversation
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
kevin-v-ngo
left a comment
kevin-v-ngo
left a comment
There was a problem hiding this comment.
Hi Florence, what should I be reviewing here?
I still see several "NOT AVAILABLE" metrics that should be removed from the docs. Is this automatically synced and will be removed at some point?
Rows for 4 metrics are no longer included for Advanced For example, with this PR, a row for However, a row for
On this page (https://www.cockroachlabs.com/docs/v25.4/essential-metrics-advanced), there are 56 metrics with "NOT AVAILABLE" in the second column because these metrics do not have a match on the Datadog site (https://docs.datadoghq.com/integrations/cockroach-cloud/#metrics). Please clarify whether these 56 rows should be displayed. |
|
discussed with @kevin-v-ngo , I will filter Essential Metrics for Advanced once #21152 is merged. |
…n the advanced_allowed_metrics and Table Statistics section and LOGICAL_DATA_REPLICATION section are now self-hosted only.
… check for visibility=ESSENTIAL. Updated metrics.yaml files by running cockroach gen metric-list > metrics.yaml against v25.4.2 and v26.1.0-beta.2 binaries.
taroface
left a comment
taroface
left a comment
There was a problem hiding this comment.
LGTM - just a small nit (typo).
| {% assign datadog_prefix = "crdb_dedicated" %} | ||
| {% comment %} Removed NETWORKING category for advanced deployment {% endcomment %} | ||
| {% assign category_order = "HARDWARE,STORAGE,OVERLOAD,DISTRIBUTED,REPLICATION,SQL,CHANGEFEEDS,TTL,CROSS_CLUSTER_REPLICATION,LOGICAL_DATA_REPLICATION,UNSET," %} | ||
| {% comment %} Removed NETWORKING AND LOGICAL_DATA_REPLICATIOON categories for advanced deployment {% endcomment %} |
There was a problem hiding this comment.
| {% comment %} Removed NETWORKING AND LOGICAL_DATA_REPLICATIOON categories for advanced deployment {% endcomment %} | |
| {% comment %} Removed NETWORKING AND LOGICAL_DATA_REPLICATION categories for advanced deployment {% endcomment %} |
| {% assign datadog_prefix = "crdb_dedicated" %} | ||
| {% comment %} Removed NETWORKING category for advanced deployment {% endcomment %} | ||
| {% assign category_order = "HARDWARE,STORAGE,OVERLOAD,DISTRIBUTED,REPLICATION,SQL,CHANGEFEEDS,TTL,CROSS_CLUSTER_REPLICATION,LOGICAL_DATA_REPLICATION,UNSET," %} | ||
| {% comment %} Removed NETWORKING AND LOGICAL_DATA_REPLICATIOON categories for advanced deployment {% endcomment %} |
There was a problem hiding this comment.
| {% comment %} Removed NETWORKING AND LOGICAL_DATA_REPLICATIOON categories for advanced deployment {% endcomment %} | |
| {% comment %} Removed NETWORKING AND LOGICAL_DATA_REPLICATION categories for advanced deployment {% endcomment %} |
…rics.yaml against v25.4.3 and v26.1.0-rc.1 binaries.
3 participants
Fixes DOC-15338 DOC-15492
In essential-metrics.md,
(a) for advanced only, show metrics that exist in the advanced_allowed_metrics list created from crdb_metrics.yaml and shared_metrics.yaml and
(b) Table Statistics section and LOGICAL_DATA_REPLICATION section are now self-hosted only.
(c) modified check for essential metrics to also check for visibility=ESSENTIAL.
Updated metrics.yaml files by running cockroach gen metric-list > metrics.yaml against v25.4.3 and v26.1.0-rc.1 binaries.
NOTE: sys_host_disk_iopsinprogress is in crdb_metrics.yaml so sys.host.disk.iopsinprogress appears for advanced.
Rendered preview