Feat lesson 26 - Library Springboot Integration#605
Closed
Dlafferty251 wants to merge 4 commits intocode-differently:mainfrom
Closed
Feat lesson 26 - Library Springboot Integration#605Dlafferty251 wants to merge 4 commits intocode-differently:mainfrom
Dlafferty251 wants to merge 4 commits intocode-differently:mainfrom
Conversation
…d creating a new book.
* fix: lombok dependency update * chore: formatting (indent)
VicenteVigueras
suggested changes
May 6, 2025
Contributor
There was a problem hiding this comment.
It looks like your branch is behind, there shouldn't be any modifications to this file
| MediaItem item = MediaItemRequest.asMediaItem(itemCreation); | ||
| library.addMediaItem(item, librarian); | ||
|
|
||
| CreateMediaItemResponse response = |
Contributor
There was a problem hiding this comment.
There's a static method called from() in the MediaItemResponse class that would be more appropriate in this line:
CreateMediaItemResponse.builder().item(getItemById(item.getId()).getBody()).build();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside of this file you will find that I have updated the mediaitemscontroller file.