fix: use fallback chain when connected-providers cache missing#1314
Open
evsong wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix: use fallback chain when connected-providers cache missing#1314evsong wants to merge 1 commit intocode-yeongyu:devfrom
evsong wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
When connected-providers.json cache doesn't exist (first run or cache cleared), the model resolver was skipping the entire fallback chain and falling through to systemDefaultModel. This caused all category-specific model configurations to be ignored. Fix: Use the first entry in fallback chain instead of skipping to systemDefault. This ensures category models (quick, visual-engineering, etc.) work correctly even without the cache. Fixes code-yeongyu#1264
Contributor
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign the CLA, please comment on this PR with: This is a one-time requirement. Once signed, all your future contributions will be automatically accepted. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connected-providers.jsoncache doesn't existProblem
When
connected-providers.jsoncache is missing (first run or cache cleared),resolveModelWithFallback()was skipping the entire fallback chain and falling through tosystemDefaultModel. This caused all category-specific model configurations (quick, visual-engineering, ultrabrain, etc.) to be ignored.Related Issues: #1264, #1295
Solution
When cache is
null, use the first entry in the fallback chain instead of skipping:Testing
Summary by cubic
Fixes category-specific model selection when connected-providers.json is missing by using the first fallback chain entry instead of the system default. Ensures categories like quick, visual-engineering, and ultrabrain use their intended models on first run or after cache clear.
Written for commit 7ef706f. Summary will update on new commits.