fix(doctor): display user-configured variant in model resolution output #1361
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
edxeth
force-pushed
the
fix/doctor-variant-display
branch
from
7e00516 to
f669428
Compare
OmoConfig interface was missing variant property, causing doctor to show variants from ModelRequirement fallback chain instead of user's config. - Add variant to OmoConfig agent/category entries - Add userVariant to resolution info interfaces - Update getEffectiveVariant to prioritize user variant - Add tests verifying variant capture
edxeth
force-pushed
the
fix/doctor-variant-display
branch
from
f669428 to
81a2317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OmoConfiginterface was missingvariantproperty, causing doctor to display variants fromModelRequirementfallback chain instead of user's configChanges
varianttoOmoConfigagent/category entriesuserVarianttoAgentResolutionInfoandCategoryResolutionInfogetEffectiveVariant()to prioritize user variant over requirement defaultsBefore/After
Summary by cubic
Fixes the doctor command to correctly display user-configured model variants in the model resolution output. Captures user variants for agents and categories and prioritizes them over fallback defaults; adds tests to cover both cases.
Written for commit 81a2317. Summary will update on new commits.