fix: Handle non-dict previous_result in bundle analysis processor#516
Draft
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Draft
fix: Handle non-dict previous_result in bundle analysis processor#516seer-by-sentry[bot] wants to merge 1 commit intomainfrom
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
==========================================
- Coverage 93.82% 93.81% -0.01%
==========================================
Files 1279 1279
Lines 46084 46087 +3
Branches 1511 1511
==========================================
+ Hits 43237 43238 +1
- Misses 2539 2541 +2
Partials 308 308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WORKER-Q80. The issue was that: Celery task chain initialized with list
[]instead of expected dictionary, causingprevious_result.get()to fail.previous_resultis a dictionary.previous_resultis not a dictionary, log a warning with relevant context and initializeprocessing_resultsto an empty list to prevent errors.This fix was generated by Seer in Sentry, triggered by Max Weng. 👁️ Run ID: 1649849
Not quite right? Click here to continue debugging with Seer.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.