Open
Conversation
2270741 to
82e616e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
- Coverage 92.78% 92.61% -0.17%
==========================================
Files 36 37 +1
Lines 1358 1395 +37
Branches 273 281 +8
==========================================
+ Hits 1260 1292 +32
- Misses 68 72 +4
- Partials 30 31 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
thomasrockhu-codecov
requested changes
Mar 19, 2024
Contributor
thomasrockhu-codecov
left a comment
There was a problem hiding this comment.
Looks great, thanks @benregn! Just some changes. Do you also have a semaphore CI run to run this off of?
82e616e to
14c7232
Compare
Author
|
@thomasrockhu-codecov Thank you for the feedback! Overlooked that those lines weren't needed anymore 🤦 We're using Semaphore at my place of work. |
Author
|
@thomasrockhu-codecov ping 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1238 🙌