Removed netstat_job_info calls and removed Start/Stop action on Debug Service#3056
Removed netstat_job_info calls and removed Start/Stop action on Debug Service#3056sebjulliand wants to merge 4 commits intomasterfrom
netstat_job_info calls and removed Start/Stop action on Debug Service#3056Conversation
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
updateConnectedBar is indirectly called twice already Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
👋 A new build is available for this PR based on 3ddcdc1. |
|
@SanjulaGanepola @mkwan01 any chance one of you can test this PR? Neither @sebjulliand or I have a debug service working. It requires a 7.6 vm. |
|
Our 7.6 machine requires an update to the Navigator. I will test the changes after the update. |
@sebjulliand While this is true, I personally like having the stop/start actions in VS Code for convenience. If we do want to still promote users to use iNav instead for this, can we add a VS Code Setting to enable these options (can be disabled by default)? What do you think? Unless there is in fact a difference in how it is started in iNav vs VS Code? |
|
@sebjulliand @SanjulaGanepola I also prefer to keep the start/stop actions, as it is more convenient to do everything inside VS Code, without switching to a Navigator browser. I am OK if this is controlled by a setting and it is disabled by default. |
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
|
@SanjulaGanepola @mkwan01 fair enough, I've put the start/stop actions back. |
Changes
This PR removes the queries to
netstat_job_infoas it requires*IOSYSCFGspecial authority since 7.6.It was used to retrieve the debug server and service job information.
The queries are replaced by queries to
job_info, using the service and server job names (as they are not supposed to change).The PR also removes the start/stop actions on the Debug Service item in the IBM i Debugger view as it's now iNav reponsibility to manage the debug service.
Finally, a direc call to
updateConnectedBarhas been removed as it turns out it's already called twice when the user connects (indirect calls).How to test this PR
Checklist