Skip to content

Removed netstat_job_info calls and removed Start/Stop action on Debug Service#3056

Open
sebjulliand wants to merge 4 commits intomasterfrom
removeDebugCheck
Open

Removed netstat_job_info calls and removed Start/Stop action on Debug Service#3056
sebjulliand wants to merge 4 commits intomasterfrom
removeDebugCheck

Conversation

@sebjulliand
Copy link
Member

Changes

This PR removes the queries to netstat_job_info as it requires *IOSYSCFG special authority since 7.6.
It was used to retrieve the debug server and service job information.

The queries are replaced by queries to job_info, using the service and server job names (as they are not supposed to change).

The PR also removes the start/stop actions on the Debug Service item in the IBM i Debugger view as it's now iNav reponsibility to manage the debug service.

Finally, a direc call to updateConnectedBar has been removed as it turns out it's already called twice when the user connects (indirect calls).

How to test this PR

  1. Connect
  2. Check the debugger status
  3. Ensure debug service can't be started from Code for i anymore
  4. Check that the service status is correctly updated once started/stopped from iNav and refreshed in Code for i

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
updateConnectedBar is indirectly called twice already

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added this to the 3.0.0 milestone Feb 3, 2026
@sebjulliand sebjulliand requested a review from a team February 3, 2026 13:41
@sebjulliand sebjulliand self-assigned this Feb 3, 2026
@sebjulliand sebjulliand added the enhancement New feature or request label Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

👋 A new build is available for this PR based on 3ddcdc1.

@worksofliam
Copy link
Member

@SanjulaGanepola @mkwan01 any chance one of you can test this PR? Neither @sebjulliand or I have a debug service working. It requires a 7.6 vm.

@worksofliam worksofliam requested review from SanjulaGanepola and mkwan01 and removed request for a team February 5, 2026 14:55
@mkwan01
Copy link
Collaborator

mkwan01 commented Feb 5, 2026

Our 7.6 machine requires an update to the Navigator. I will test the changes after the update.

@SanjulaGanepola
Copy link
Member

SanjulaGanepola commented Feb 5, 2026

The PR also removes the start/stop actions on the Debug Service item in the IBM i Debugger view as it's now iNav reponsibility to manage the debug service.

@sebjulliand While this is true, I personally like having the stop/start actions in VS Code for convenience. If we do want to still promote users to use iNav instead for this, can we add a VS Code Setting to enable these options (can be disabled by default)? What do you think?

Unless there is in fact a difference in how it is started in iNav vs VS Code?

@mkwan01
Copy link
Collaborator

mkwan01 commented Feb 5, 2026

@sebjulliand @SanjulaGanepola I also prefer to keep the start/stop actions, as it is more convenient to do everything inside VS Code, without switching to a Navigator browser. I am OK if this is controlled by a setting and it is disabled by default.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Copy link
Member Author

@SanjulaGanepola @mkwan01 fair enough, I've put the start/stop actions back.
Back to you for approval. Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants