Skip to content

docs: clarify error handlers are final and don't call next() #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
code-asher merged 3 commits into from
Jan 28, 2026
+12 −0
Merged

docs: clarify error handlers are final and don't call next() #7646

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1eb2b7
fix: enhance WebSocket error handling with status code logging
taosin Jan 24, 2026
6f601e9
feat: add final error handlers for HTTP and WebSocket with detailed d…
taosin Jan 27, 2026
9388cce
Merge branch 'coder:main' into code-108.1
taosin Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/node/routes/errors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,8 @@ export const wsErrorHandler: express.ErrorRequestHandler = async (err, req, res,
} else {
logger.debug(`${err.message} ${err.stack}`)
}
// Close the WebSocket connection with the appropriate HTTP status code.
// We don't call next() here because the error has been fully handled:
// the connection is closed and the error has been logged.
;(req as WebsocketRequest).ws.end(`HTTP/1.1 ${statusCode} ${err.message}\r\n\r\n`)
}