Skip to content

fix: invalid references to http client & cli #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fioan89 merged 3 commits into from
Feb 3, 2026
Merged

fix: invalid references to http client & cli #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db26667
chore: remove dead code
fioan89 Feb 2, 2026
c4bdc18
fix: invalid references to http client and & cli
fioan89 Feb 2, 2026
f435357
chore: update changelog
fioan89 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@

- support for configuring the SSH connection timeout, defaults to 10 seconds

### Fixed

- environment actions failing after URI execution by refreshing http client and CLI references

## 0.8.4 - 2026-01-20

### Fixed
Expand Down
14 changes: 10 additions & 4 deletions src/main/kotlin/com/coder/toolbox/CoderRemoteEnvironment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ private val POLL_INTERVAL = 5.seconds
*/
class CoderRemoteEnvironment(
private val context: CoderToolboxContext,
private val client: CoderRestClient,
private val cli: CoderCLIManager,
internal var client: CoderRestClient,
internal var cli: CoderCLIManager,
private var workspace: Workspace,
private var agent: WorkspaceAgent,
) : RemoteProviderEnvironment("${workspace.name}.${agent.name}"), BeforeConnectionHook, AfterDisconnectHook {
Expand Down Expand Up @@ -351,8 +351,6 @@ class CoderRemoteEnvironment(
}
}

fun isConnected(): Boolean = isConnected.value

/**
* An environment is equal if it has the same ID.
*/
Expand All @@ -371,4 +369,12 @@ class CoderRemoteEnvironment(
override fun toString(): String {
return "CoderRemoteEnvironment(name='$name')"
}

/**
* Update the client and CLI manager for this environment.
*/
fun updateClientAndCli(client: CoderRestClient, cli: CoderCLIManager) {
this.client = client
this.cli = cli
}
}
2 changes: 2 additions & 0 deletions src/main/kotlin/com/coder/toolbox/CoderRemoteProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,7 @@ class CoderRemoteProvider(
}
this.client = newRestClient
this.cli = newCli
lastEnvironments.forEach { it.updateClientAndCli(newRestClient, newCli) }
pollJob = poll(newRestClient, newCli)
context.logger.info("Workspace poll job with name ${pollJob.toString()} was created while handling URI")
return newRestClient to newCli
Expand Down Expand Up @@ -521,6 +522,7 @@ class CoderRemoteProvider(
}
this.client = client
this.cli = cli
lastEnvironments.forEach { it.updateClientAndCli(client, cli) }
environments.showLoadingMessage()
if (context.settingsStore.useAppNameAsTitle) {
context.logger.info("Displaying ${client.appName} as main page title")
Expand Down
Loading