fix: invalid references to http client & cli#259
Merged
Conversation
- unused methods
Each environment holds a reference to the http client and the cli mainly for operations like start, stop, update, etc... performed by either one or the other. In the past we recreated the environment instances each time we polled, effectively updating the references to the cli and http client. This was really important for the cases where Coder Toolbox was already running and a URI was executed. In this case we recreate new instances of the http client and cli that are the used by the poller to create a new list of environments. However, not too long we discovered that recreating the environments instances each time has unwanted effects. The obvious fix was to update the existing env. instances instead of creating new ones. But the update failed to take into account that the cli and http client references also need to a refresh after a URI execution. As a result, environment actions stopped working after new instances were created by the URI handler. This fix ensures those references are properly refreshed.
f0ssel
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each environment holds a reference to the http client and the cli
mainly for operations like start, stop, update, etc... performed by
either one or the other.
In the past we recreated the environment instances each time we polled,
effectively updating the references to the cli and http client.
This was really important for the cases where Coder Toolbox was already
running and a URI was executed. In this case we recreate new instances of
the http client and cli that are the used by the poller to create a new
list of environments. However, not too long we discovered that recreating
the environments instances each time has unwanted effects. The obvious fix
was to update the existing env. instances instead of creating new ones.
But the update failed to take into account that the cli and http client
references also need to a refresh after a URI execution.
As a result, environment actions stopped working after new instances were created
by the URI handler. This fix ensures those references are properly refreshed.